Various updates #28
Various updates #28
Conversation
Add Pipeline as parameter to let specific implementation use a different pipeline instead of letting normal query pipeline routing.
Fix for issue #384306. variable documentAuthor should not be more than 128 char on an analytics call to avoid errors in the analytics console
Fix for issue #381226. Labels in the result list should be displayed as list labels and not a single list item separated by semicolon (;)
Fix for issue #373500. Display simple breadcrumb in green following the latest indexing fix, using the format [hostname] > [1st element of breadcrumb]. Default to printableuri if not available.
Enable Query Suggestions in the main search box of the search results page.
bblaisATcoveo
had a problem deploying
to
github-ci
GitHub Actions
Failure
|
@GormFrank @igkislev @ipaksc Here's the latest PR, feel free to review. |
src/connector.js
Outdated
| @@ -31,11 +31,13 @@ const defaults = { | |||
| "searchBoxQuery": "#sch-inp-ac", | |||
| "lang": "en", | |||
| "numberOfSuggestions": 0, | |||
| "minimumCharsForSuggestions": 1, | |||
| "unsupportedSuggestions": false, | |||
There was a problem hiding this comment.
Please remove this line
| "unsupportedSuggestions": false, |
There was a problem hiding this comment.
Done in latest commit
src/connector.js
Outdated
| @@ -356,47 +367,19 @@ function initTpl() { | |||
| if ( !suggestionsElement && searchBoxElement && params.unsupportedSuggestions && params.numberOfSuggestions > 0 ) { | |||
There was a problem hiding this comment.
Please remove params.unsupportedSuggestions as part of the condition.
| if ( !suggestionsElement && searchBoxElement && params.unsupportedSuggestions && params.numberOfSuggestions > 0 ) { | |
| if ( !suggestionsElement && searchBoxElement && params.numberOfSuggestions > 0 ) { |
There was a problem hiding this comment.
Done in latest commit
src/connector.js
Outdated
| activeSuggestion = index + 1; | ||
| updateSuggestionSelection(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Add semicolon for readability purposes (as flagged by our build script):
| } | |
| }; |
There was a problem hiding this comment.
Done in latest commit
src/connector.js
Outdated
| searchBoxArrowKeyDown(); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Add semicolon for readability purposes (as flagged by our build script):
| } | |
| }; |
There was a problem hiding this comment.
Done in latest commit
src/connector.js
Outdated
| } | ||
| node.onmousemove = ( e ) => { | ||
| activeSuggestionWaitMouseMove = false; | ||
| } |
There was a problem hiding this comment.
Add semicolon for readability purposes (as flagged by our build script):
| } | |
| }; |
There was a problem hiding this comment.
Done in latest commit
Removed unsupportedSuggestions flag from default params and implementation
bblaisATcoveo
had a problem deploying
to
github-ci
GitHub Actions
Failure
bblaisATcoveo
had a problem deploying
to
github-ci
GitHub Actions
Failure
Review each individual commit for details