Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name length limit changed, finally!! #13

Open
Anonymous941 opened this issue Jun 30, 2024 · 5 comments
Open

Name length limit changed, finally!! #13

Anonymous941 opened this issue Jun 30, 2024 · 5 comments

Comments

@Anonymous941
Copy link

(I'll edit more details in later)

When working on #12, I remembered about how I managed to change the name length easily with the disassembly ebsrc! Here's a simple test patch to demonstrate it (source) (apply on a headered ROM). Don't care and the window lengths are not working, but I got them working in the past, so I can change them when I get more time. I don't really deserve credit for this, as ebsrc had most of the work done for me already

It will still need some work to integrate into a CoilSnake project like this, so I can work on that when I have some time

@Anonymous941 Anonymous941 changed the title Length limit changed, finally!! Name length limit changed, finally!! Jun 30, 2024
@ShadowOne333
Copy link
Owner

Oh this is really interesting.
So what's the maximum length the game takes now for names?
6 letters?

@Anonymous941
Copy link
Author

Anonymous941 commented Jul 1, 2024

Virtually unlimited, I think I got it working with 15 or 20. It requires editing of the window sizes on the title screen, and also messes up the dialog if you make too long of a name (the text becomes truncated). Also, it has the side effect of requiring you to delete your save files, not just the in-game delete option but actually deleting the files. I think it's because it changes its size, and so it starts reading garbage data

@ShadowOne333
Copy link
Owner

This looks quite promising.
If you have the time, and are willing to, please consider joining the EBB Remake server, the developer for the Remake is quite interested in this. It'd also be of great help for EarthBound hacking as a whole.

Here's the invite to the server:
https://discord.gg/N8TTRNGb

@Anonymous941
Copy link
Author

Anonymous941 commented Jul 27, 2024

@ShadowOne333 Absolutely, I'd be glad to help - I've joined as @PhoneticTeacher. I'm currently working on another project, but I should have some time for this. Note that this won't work for EarthBound Beginnings, and that doesn't have as extensive of a decompilation so it would be much harder. never mind, forgot what EBB remake is, lol

Another thing to note is that some parts of ebsrc might contain GNU-licensed software, so I'm not sure if it's legal to distribute these changes in closed source ROM hacks (not saying that the project is/will be closed source, I just don't know)

@ShadowOne333
Copy link
Owner

I think the whole licensing stuff is not an issue, given how much of the code, if not the entirety of it, for the Extended Name Length hack would have to be rewritten for CoilSnake at the end of the day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants