-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name length limit changed, finally!! #13
Comments
Oh this is really interesting. |
Virtually unlimited, I think I got it working with 15 or 20. It requires editing of the window sizes on the title screen, and also messes up the dialog if you make too long of a name (the text becomes truncated). Also, it has the side effect of requiring you to delete your save files, not just the in-game delete option but actually deleting the files. I think it's because it changes its size, and so it starts reading garbage data |
This looks quite promising. Here's the invite to the server: |
@ShadowOne333 Absolutely, I'd be glad to help - I've joined as @PhoneticTeacher. I'm currently working on another project, but I should have some time for this. Another thing to note is that some parts of ebsrc might contain GNU-licensed software, so I'm not sure if it's legal to distribute these changes in closed source ROM hacks (not saying that the project is/will be closed source, I just don't know) |
I think the whole licensing stuff is not an issue, given how much of the code, if not the entirety of it, for the Extended Name Length hack would have to be rewritten for CoilSnake at the end of the day. |
(I'll edit more details in later)
When working on #12, I remembered about how I managed to change the name length easily with the disassembly ebsrc! Here's a simple test patch to demonstrate it (source) (apply on a headered ROM). Don't care and the window lengths are not working, but I got them working in the past, so I can change them when I get more time. I don't really deserve credit for this, as ebsrc had most of the work done for me already
It will still need some work to integrate into a CoilSnake project like this, so I can work on that when I have some time
The text was updated successfully, but these errors were encountered: