-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buf() mishandles [3, 0, 0, 0, 0] #9
Comments
Never mind … I didn’t realize this computes a signed value rather than unsigned. |
"The return value is a signed 32-bit integer." See the discussion from an older issue. Basically V8 has a special optimization for 32-bit signed integers which is generally awesome but performs extremely poorly for naive CRC calculations |
Might be nice to include a convenience that does the signed-to-unsigned conversion? I think it's just: |
Even easier: |
The text was updated successfully, but these errors were encountered: