Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce authorization checks for Bookmarks, Folders, and Saved Search APIs #117

Open
richardxia opened this issue Jun 20, 2024 · 0 comments
Assignees

Comments

@richardxia
Copy link
Member

The first pass at these endpoints are probably going to be merged without performing authorization checks. This ticket is meant to track the task of actually enforcing authorization checks for these endpoints, which we'll want before launch.

Specifically, for the MVP, we want to enforce that the authenticated user (via the JWT) matches the user in the actual database user_id foreign key column for each of these resources.

Post-MVP, we may want to loosen this if we want to enable a feature for users to share bookmarks, folders, or saved searches with each other, but we need a lot more discussion about how that should work in our app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Status: No status
Development

No branches or pull requests

2 participants