Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Swipeable when used with FlashList #366

Closed
fortmarek opened this issue May 2, 2022 · 9 comments
Closed

Optimize Swipeable when used with FlashList #366

fortmarek opened this issue May 2, 2022 · 9 comments
Assignees

Comments

@fortmarek
Copy link
Contributor

When benchmarking Swipeable, we have found a couple of issues making the component slower than expected. We should strive for Swipeable causing max 5 % performance drop.

@fortmarek fortmarek added this to the v0.5 milestone May 2, 2022
@fortmarek fortmarek self-assigned this May 2, 2022
@naqvitalha naqvitalha removed this from the v0.5 milestone May 12, 2022
@hirbod
Copy link
Contributor

hirbod commented Sep 11, 2022

@fortmarek where can I find this mysterious react-native-swipe-actions package? :)

@fortmarek
Copy link
Contributor Author

where can I find this mysterious react-native-swipe-actions package? :)

This is, for the time being, unfortunately an internal package

@erennyuksell
Copy link

@hirbod i tried with react-native-gesture-handler's Swipeable there is a dramatic drop in performance

@hirbod
Copy link
Contributor

hirbod commented Aug 27, 2023

@hirbod i tried with react-native-gesture-handler's Swipeable there is a dramatic drop in performance

Did you memoize the Gesture object with useMemo? That's super important.

@Acetyld
Copy link

Acetyld commented Oct 13, 2023

Same problem here, massive performance drop while using swipeable from gesture-handle

@K-Leon
Copy link

K-Leon commented Oct 28, 2023

Found anyone a solution?

@Acetyld
Copy link

Acetyld commented Oct 29, 2023

Found anyone a solution?

We haven’t, hope the flashlist team can look in to this, we sadly dropped feature for now

@erennyuksell
Copy link

@hirbod i tried with react-native-gesture-handler's Swipeable there is a dramatic drop in performance

Did you memoize the Gesture object with useMemo? That's super important.

yes i memorized

@Acetyld
Copy link

Acetyld commented Nov 3, 2023

Same here, any kind of memo no success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants