Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Performance.mark annotations #1479

Open
Tracked by #1476
blittle opened this issue Jun 8, 2022 · 1 comment · May be fixed by #1534
Open
Tracked by #1476

Add Performance.mark annotations #1479

blittle opened this issue Jun 8, 2022 · 1 comment · May be fixed by #1534

Comments

@blittle
Copy link
Contributor

blittle commented Jun 8, 2022 •
edited
Loading

We need to make it easier to benchmark Hydrogen performance. We can do that by adding Performance.mark annotations throughout the page load. We should also add these annotations on page transitions, before as the RSC request starts and once it finishes.
@blittle blittle mentioned this issue Jun 8, 2022
Open
5 tasks
@blittle blittle changed the title We need to make it easier to benchmark Hydrogen performance. We can do that by adding Performance.mark annotations throughout the page load. We should also add these annotations on page transitions, before as the RSC request starts and once it finishes. Add Performance.mark annotations Jun 8, 2022
@blittle blittle linked a pull request Jun 10, 2022 that will close this issue
Open
4 tasks
@cartogram
Copy link
Contributor

@blittle I added a one here https://github.com/Shopify/hydrogen/pull/1548/files#diff-9ebe85c3af0d45449b8ef90a3a0e3e17386315e8bf3928028baef855495e3b64R172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add client performance markers and measurements Shopify/hydrogen-v1
2 participants
@cartogram @blittle