Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite renderToReadableStream error after upgrading cli-hydrogen from 7 to 8.0.4 #2174

Open
belazaras opened this issue May 30, 2024 · 4 comments

Comments

@belazaras
Copy link

What is the location of your example repository?

No response

Which package or tool is having this issue?

CLI

What version of that package or tool are you using?

8.0.4

What version of Remix are you using?

2

Steps to Reproduce

just launch shopify hydrogen dev and navigate to localhost.

Expected Behavior

it should just work.

Actual Behavior

image tried many things and didn't work, included what's suggested in the image. also compared to a new install but can't figure what old code might be breaking it, or which packages might be incompatible.
@frandiox
Copy link
Contributor

frandiox commented May 31, 2024

Did you use h2 setup vite to migrate?
Make sure your vite.config.js is something like this and that you have "type": "module" in your package.json

Also, as per the release notes, make sure you have installed @shopify/mini-oxygen in your project.

@belazaras
Copy link
Author

h2 setup vite says command not found.
all the rest I did and when booting server it throws this exports error now:
image

@frandiox
Copy link
Contributor

frandiox commented Jun 4, 2024

Try with what's explained here: #2129 (comment)

@belazaras
Copy link
Author

If I add remix-run/dev to ssr.optimizeDeps.include which is where the exports is not defined, it causes a trillion other issues for vite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants