Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deep search for filter taking in properties #1749

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

andershagbard
Copy link
Contributor

@andershagbard andershagbard commented Oct 16, 2023

This PR allows for backward compatibility deep search :woah:

Like so:

{{ input | where: 'some.nested.property', 'foo', deep: true }}
{{ input | where: 'some_nested_property', 'foo', deep: '_' }} # Custom separator

Added deep search for the following filters. This should be all Liquid filters which takes in a property argument:

  • map
  • sort
  • sort_natural
  • sum
  • uniq
  • where
  • compact

@andershagbard
Copy link
Contributor Author

@dylanahsmith I am not sure if you still work on Liquid, but I would love for someone in the Liquid team to take a look at this PR.

@andershagbard
Copy link
Contributor Author

@karreiro @benjaminsehl ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant