Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict between lhm.rbi and lhm-shopify.rbi #104

Open
ghost opened this issue Sep 13, 2022 · 1 comment
Open

Conflict between lhm.rbi and lhm-shopify.rbi #104

ghost opened this issue Sep 13, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Sep 13, 2022

Problem

The lhm.rbi and lhm-shopify.rbi annotations don't play nicely with each other. This error ends up raised during a typecheck:
image

Looks like these are the conflicting lines:

sig { params(lowest: T.nilable(Numeric), highest: T.nilable(Numeric)).void }
def notify(lowest = nil, highest = nil); end

sig { params(_arg0: T.untyped).void }
def notify(*_arg0); end

Context

@KaanOzkan KaanOzkan added the bug Something isn't working label Sep 14, 2022
@Morriar
Copy link
Contributor

Morriar commented Sep 15, 2022

I think lhm actually points to https://github.com/soundcloud/lhm.

In any case if I look at both repos:

It seems that the signature for Lhm::Printer::Dot#notify is wrong in our RBI and need to be fixed.

Morriar added a commit that referenced this issue Sep 15, 2022
Closes #104.

Signed-off-by: Alexandre Terrasa <[email protected]>
@Morriar Morriar self-assigned this Oct 17, 2022
@Morriar Morriar removed their assignment Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants