We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The lhm.rbi and lhm-shopify.rbi annotations don't play nicely with each other. This error ends up raised during a typecheck:
lhm.rbi
lhm-shopify.rbi
Looks like these are the conflicting lines:
rbi-central/rbi/annotations/lhm.rbi
Lines 94 to 95 in 5fd791d
rbi-central/rbi/annotations/lhm-shopify.rbi
Lines 84 to 85 in 5fd791d
lhm
shopify_lhm
3.3.4
1.0.1
0.10.0
0.6.11
The text was updated successfully, but these errors were encountered:
I think lhm actually points to https://github.com/soundcloud/lhm.
In any case if I look at both repos:
It seems that the signature for Lhm::Printer::Dot#notify is wrong in our RBI and need to be fixed.
Lhm::Printer::Dot#notify
Sorry, something went wrong.
Fix signature for Lhm::Printer::Dor#notify
Lhm::Printer::Dor#notify
1aabcaf
Closes #104. Signed-off-by: Alexandre Terrasa <[email protected]>
Successfully merging a pull request may close this issue.
Problem
The
lhm.rbi
andlhm-shopify.rbi
annotations don't play nicely with each other. This error ends up raised during a typecheck:Looks like these are the conflicting lines:
rbi-central/rbi/annotations/lhm.rbi
Lines 94 to 95 in 5fd791d
rbi-central/rbi/annotations/lhm-shopify.rbi
Lines 84 to 85 in 5fd791d
Context
lhm
&shopify_lhm
3.3.4
& shopify_lhm is1.0.1
.0.10.0
0.6.11
The text was updated successfully, but these errors were encountered: