Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signature for Lhm::Printer::Dot#notify #106

Closed
wants to merge 1 commit into from
Closed

Conversation

Morriar
Copy link
Contributor

@Morriar Morriar commented Sep 15, 2022

Type of Change

  • Add RBI for a new gem
  • Modify RBI for an existing gem
  • Other:

Changes

Closes #104.

@Morriar Morriar added the rbi Change related to RBI annotations label Sep 15, 2022
@Morriar Morriar self-assigned this Sep 15, 2022
@Morriar Morriar requested a review from a team as a code owner September 15, 2022 17:23
Copy link
Contributor

@KaanOzkan KaanOzkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have conflict with tapioca 😄

@Morriar Morriar changed the title Fix signature for Lhm::Printer::Dor#notify Fix signature for Lhm::Printer::Dot#notify Oct 13, 2022
@andyw8
Copy link
Contributor

andyw8 commented Jan 30, 2024

Just ran into this for #216, what's the right way forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rbi Change related to RBI annotations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict between lhm.rbi and lhm-shopify.rbi
3 participants