Sidekiq 7.0 incompatible with current sidekiq annotations

[leifg]

Problem

When running type on a project that uses the latest sidekiq version, I will get this type error:

sorbet/rbi/gems/[email protected]:2965: Cannot initialize the module Worker by constant assignment https://srb.help/4022
    2965 |Sidekiq::Worker = Sidekiq::Job
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    sorbet/rbi/annotations/sidekiq.rbi:79: Previously defined as a module here
    79 |module Sidekiq::Worker
        ^^^^^^^^^^^^^^^^^^^^^^
  Note:
    Sorbet does not allow treating constant assignments as class or module definitions,
    even if the initializer computes a Module object at runtime. See the docs for more.

At first glance this doesn't seem to an issue of annotations, but changing all references of Sidekiq::Worker to Sidekiq::Job in sorbet/rbi/annotations/sidekiq.rbi fixes the issue.

Weirdly enough, when changing the references in a project that uses sidekiq < 7.0.0 also causes an error:

Method sidekiq_options does not exist on T.class_of(MyJob) https://srb.help/7003

Seems like a good use case for versioning

Context

I'm using include Sidekiq::Job in all my workers (in 6.0. and 7.0)

Sidekiq aliases Sidekiq::Job to Sidekiq::Worker. Weirdly enough this has not been introduced in 7.0 and has been there before.

• Gem name: sidekiq
• Gem version: 7.0.0
• Tapioca version: 0.10.2
• Sorbet version: 0.5.10517

[KaanOzkan]

This is probably new because of a Sorbet a upgrade. It's better to support latest versions so feel free to open a PR that changes the annotation to use Job. It's encouraged in https://github.com/mperham/sidekiq/blob/636fa9a06a50e2437d91fa21be64a9bf233369c7/lib/sidekiq/worker_compatibility_alias.rb#L4-L11