Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate signatures at runtime #96

Open
Morriar opened this issue Aug 17, 2022 · 0 comments
Open

Validate signatures at runtime #96

Morriar opened this issue Aug 17, 2022 · 0 comments
Labels
ci Change related to CI

Comments

@Morriar
Copy link
Contributor

Morriar commented Aug 17, 2022

Problem

Right now we only operate a few checks on the runtime validity of an annotations file:

  • Require can be done
  • Constants
  • Constants are of the right kind (ie. classes are classes)
  • Method exists (or can be delegated to method_missing

But we currently do not check if:

  • The method arity in the RBI is correct
  • The params are of the right type in the signature
  • The return type is of the right type in the signature

This would be another step in ensuring our annotations are correct.
@Morriar Morriar added the ci Change related to CI label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Change related to CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Morriar