From 4f5e0c7e22cc1b03203bb1cfbd49f948b4b3094c Mon Sep 17 00:00:00 2001 From: Chris Berthe Date: Wed, 5 Jul 2017 14:27:42 -0400 Subject: [PATCH] Fix slate test command passing on Circle CI (#72) --- src/tasks/includes/lint-reporter.js | 4 ++++ src/tasks/includes/messages.js | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/src/tasks/includes/lint-reporter.js b/src/tasks/includes/lint-reporter.js index dcbb3c61..cbf4d91e 100644 --- a/src/tasks/includes/lint-reporter.js +++ b/src/tasks/includes/lint-reporter.js @@ -1,6 +1,8 @@ const gutil = require('gulp-util'); const _ = require('lodash'); +const messages = require('./messages.js'); + /** Class representing a custom reporter for @shopify/theme-lint */ export default class Reporter { constructor() { @@ -53,6 +55,8 @@ export default class Reporter { return gutil.log(failure[0]); }); }); + + throw new Error(messages.translationsFailed()); } this.successes = this.failures = []; diff --git a/src/tasks/includes/messages.js b/src/tasks/includes/messages.js index 2e7b4432..8e2114da 100644 --- a/src/tasks/includes/messages.js +++ b/src/tasks/includes/messages.js @@ -73,6 +73,10 @@ const messages = { ' and run a full as a result.'; }, + translationsFailed: () => { + return 'Translation errors detected.'; + }, + invalidThemeId: (themeId, env) => { gutil.log('Invalid theme id for', gutil.colors.cyan(`${env}: ${themeId}`),