Add Tests and Fix Comparison Bug in Spoom::Location
#585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
reviewed
Jul 12, 2024
andyw8
reviewed
Jul 12, 2024
andyw8
reviewed
Jul 12, 2024
|
Thanks for improving the coverage! |
alexcrocha
force-pushed
the
ar/location-tests
branch
from
e2e0114 to
f3cc42a
Compare
Morriar
reviewed
Jul 22, 2024
alexcrocha
force-pushed
the
ar/location-tests
branch
from
f3cc42a to
ad88da3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the lack of tests for the
Spoom::Locationclass by introducing test coverage for its methods.Details
Test Coverage: Added tests to ensure all methods in
Spoom::Locationfunction as expected.Bug Fix: During the creation of these tests, a logical bug was identified in the implementation of the
<=>method. The current implementation only compares strings, which leads to incorrect comparisons for integers (e.g.,"11" < "2"evaluates as true, but2 < 11is the correct comparison).