Ignore *Test named classes again
#593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
approved these changes
Jul 29, 2024
nvasilevski
deleted the
bring-back-ignore-of-all-Test-classes-to-minitest
branch
|
@nvasilevski do you mean creating a new Spoom release with this fix please? 🙏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #579
Not ignoring classes named
*Testend up resulting in a bug where test classes that inherit from Rails' framework specific test class likeActiveJob::TestCasestarted to be considered dead. #592All of the framework test cases inherit from
ActiveSupport::TestCaseso ultimately it should be enough to have it ignoredspoom/lib/spoom/deadcode/plugins/active_support.rb
Line 8 in d4ccf20
should suffice but at the moment spoom doesn't see the
AJ::TestCase < AS::TestCaseinheritance chain so until we get it fixed we are bringing the*Testignore rule back