Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deadcode detector does not detect &:method usages of a method #606

Closed
phaselockedloop opened this issue Sep 23, 2024 · 1 comment · Fixed by #609
Closed

Deadcode detector does not detect &:method usages of a method #606

phaselockedloop opened this issue Sep 23, 2024 · 1 comment · Fixed by #609
Labels
bug Something isn't working

Comments

@phaselockedloop
Copy link

For example:

abc.map(&method(xyz))

xyz is identified as unused when it is in fact used through this indirection.
@Morriar Morriar mentioned this issue Sep 30, 2024
Merged
@Morriar
Copy link
Collaborator

Morriar commented Sep 30, 2024

Thanks for the simple repro! 🙏

Fix: #609

@Morriar Morriar added the bug Something isn't working label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add deadcode plugin handling for Object#method Shopify/spoom
2 participants
@Morriar @phaselockedloop