Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically resolve superclass redefinition errors while generating gem RBIs #1834

Open
KaanOzkan opened this issue Mar 20, 2024 · 0 comments
Labels
enhancement New feature or request good-first-issue Good for newcomers rubyconf-hackday

Comments

@KaanOzkan
Copy link
Contributor

We already typecheck resulting RBIs to convert strictness to false:

def validate_rbi_files(command:, gem_dir:, dsl_dir:, auto_strictness:, gems: [], compilers: [])

Similarly if we run into a superclass redefinition error we can populate sorbet/config with --suppress-payload-superclass-redefinition-for=ConstantName to prevent typecheck errors.

We probably will want to update the payload as well so this should still inform the user about the mismatch that's happening instead of fixing it silently.

@KaanOzkan KaanOzkan added enhancement New feature or request good-first-issue Good for newcomers labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good-first-issue Good for newcomers rubyconf-hackday
Projects
None yet
Development

No branches or pull requests

2 participants