This repository was archived by the owner on Jul 27, 2024. It is now read-only.
Add a new VariableName check #717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require variable names to be snake_case
Darhazer
commented
Feb 25, 2023
| # frozen_string_literal: true | ||
| module ThemeCheck | ||
| class VariableName < LiquidCheck | ||
| severity :suggestion |
|
@Darhazer This PR dead? 😢 |
|
@tmmgrafikr seems to me theme-check is not really maintained. |
Do you use this custom check yourself? |
|
I'm not using theme-check at the moment. |
|
Created an update PR of this here: Shopify/theme-tools#359 |
|
👋🏻 Hi all, given that the theme-tools update that does this has been merged, I'm going to be closing this PR. This repository is no longer maintained. Thank you for your contributions! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Shopify/theme-tools#447 this check requires that variable names use snake_case
This is my first theme check so any feedback is welcome. As a learning exercise, I intend to do
allmost of the checks suggested in Shopify/theme-tools#447 so if anything there is outdated, I'd appreciate updating.