Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Turbolinks #165

Open
marutypes opened this issue Oct 13, 2016 · 0 comments
Open

Refactor Turbolinks #165

marutypes opened this issue Oct 13, 2016 · 0 comments

Comments

@marutypes
Copy link
Contributor

marutypes commented Oct 13, 2016

So, I've talked about this in private with a few of you, and I have brought it up in some of the recent PRs as well. I'm just opening this issue to keep track of things and also to allow some public discussion.

I think our domain model is wrong and causes changes to take longer than they should. I'd specifically like to take Turbolinks.visit into more of an 'instantiating a visit object' direction, and away from the current strategy of having a bunch of static methods and an options object that we mutate.

I'll probably be away from this repo for a bit but I'd like to come back to this (and the other open issues) by the end of the year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant