Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial refresh'ing with a response that contains an <iframe> changes title #171

Open
tedtate opened this issue Nov 1, 2016 · 4 comments
Labels

Comments

@tedtate
Copy link

tedtate commented Nov 1, 2016

Steps to reproduce

  1. Trigger a partial refresh on a page where the XHR response contains an iframe (This is easy to repro within Shopify if you would like a link).

Results

The title of the page is updated to Edit Comment.
This also might cause some other side-effects which I'm not aware of.

Why does this happen?

Turbograft contains a regex which tries to determine whether a response is a new html document or not and this trips it up:

.

@TheMallen @GoodForOneFare
@Shopify/tnt

@tedtate tedtate added the bug label Nov 2, 2016
@marutypes
Copy link
Contributor

Neat.

@marutypes
Copy link
Contributor

A link would be great.

@tedtate
Copy link
Author

tedtate commented Nov 7, 2016

Link: https://tedtesting.myshopify.com/admin/customers/3529140803 (You can go nuts testing on there, just a test shop).

@tedtate
Copy link
Author

tedtate commented Dec 5, 2016

@TheMallen have you get a chance to look at this yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants