Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

muVT_sim docs out of date #233

Closed
SimonEnsemble opened this issue Dec 6, 2022 · 2 comments
Closed

muVT_sim docs out of date #233

SimonEnsemble opened this issue Dec 6, 2022 · 2 comments
Assignees

Comments

@SimonEnsemble
Copy link
Owner

kwargs for the muVT_sim out of date

https://github.com/SimonEnsemble/PorousMaterials.jl/blob/master/src/gcmc.jl#L181-L182

does not match the docs https://simonensemble.github.io/PorousMaterials.jl/dev/gcmc/ n_sample_cycles.

also, if we want to run with one cycle, this is impossible to do with current setup. think this can be done via n_cycles_per_volume being a Float. and making min of 1.

@SimonEnsemble
Copy link
Owner Author

IOError: mkdir("/Users/cokes/.julia/pluto_notebooks/data/simulations"; mode=0o777): no such file or directory (ENOENT)```

create directory for snapshots file if it doesn't exist

@eahenle
Copy link
Collaborator

eahenle commented Jun 26, 2024

resolved in v0.5

@eahenle eahenle closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants