Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1]: Post count membergroup can be changed to "Private" but not the other way around #8324

Open
LexArma opened this issue Oct 13, 2024 · 5 comments

Comments

@LexArma
Copy link
Member

LexArma commented Oct 13, 2024

Basic Information

You can modify a post count group making it private, which can be handy - But you should also be able to reverse this, yet currently trying apparently errors out.

Steps to reproduce

Admin > Members > Membergroups. Modify post count group to Private - works. Modify back to Post Based, fails.

Expected result

The change should work both way, or it shouldn't be possible to begin with.

Actual result

Fatal error: Uncaught TypeError: abs(): Argument #1 ($num) must be of type int|float, string given in /home/thekrash/domains/thekrashsite.com/public_html/smf21core/Sources/ManageMembergroups.php:740 Stack trace: #0 /home/thekrash/domains/thekrashsite.com/public_html/smf21core/Sources/ManageMembergroups.php(740): abs() #1 /home/thekrash/domains/thekrashsite.com/public_html/smf21core/Sources/Subs.php(6030): EditMembergroup() #2 /home/thekrash/domains/thekrashsite.com/public_html/smf21core/Sources/ManageMembergroups.php(66): call_helper() #3 /home/thekrash/domains/thekrashsite.com/public_html/smf21core/Sources/Admin.php(499): ModifyMembergroups() #4 /home/thekrash/domains/thekrashsite.com/public_html/smf21core/index.php(184): AdminMain() #5 {main} thrown in /home/thekrash/domains/thekrashsite.com/public_html/smf21core/Sources/ManageMembergroups.php on line 740

Version/Git revision

2.1.4

Database Engine

All

Database Version

No response

PHP Version

No response

Logs

No response

Additional Information

Report here by Sir Osis https://www.simplemachines.org/community/index.php?topic=589982

@live627
Copy link
Contributor

live627 commented Oct 15, 2024

spam removed

@Oldiesmann
Copy link
Contributor

I would think you shouldn't be able to change it at all. If they want to make it a regular group instead they can delete the post count group and make a new one.

@LexArma
Copy link
Member Author

LexArma commented Oct 23, 2024

Yeah, that does seem like a sensible solution - if it breaks stuff, don't allow it in the first place.

@Oldiesmann
Copy link
Contributor

@live627 Can you kill that spam?

@SimpleMachines SimpleMachines deleted a comment from Jackharrysd Oct 25, 2024
@live627
Copy link
Contributor

live627 commented Oct 25, 2024

lol lex got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants