Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project generator needs to provide better error messages. #35

Open
YellowOnion opened this issue May 31, 2021 · 12 comments
Open

Project generator needs to provide better error messages. #35

YellowOnion opened this issue May 31, 2021 · 12 comments

Comments

@YellowOnion
Copy link

Files are available here: https://docs.godotengine.org/en/stable/tutorials/3d/fps_tutorial/part_one.html

Regenerating ...
["game/Main.gdns"]
["game/Health_Pickup.tscn","game/Testing_Area.tscn","game/Broken_Target.tscn","game/Ammo_Pickup.tscn","game/Turret.tscn","game/Debug_Display.tscn","game/Target.tscn","game/Main.tscn","game/Pause_Popup.tscn","game/Sticky_Grenade.tscn","game/Simple_Audio_Player.tscn","game/Main_Menu.tscn","game/Grenade.tscn","game/Bullet_Scene.tscn","game/Player.tscn","game/assets/Ruin_Level_Objects/Debris.tscn","game/assets/Ruin_Level_Objects/Ruin_Level_Library_Scene.tscn","game/assets/Ruin_Level_Objects/Ruins_Level.tscn","game/assets/Ruin_Level_Objects/Debris_Pillar.tscn","game/assets/Gamemode_Objects/Banner_Red.tscn","game/assets/Gamemode_Objects/Gamemode_Flag_Red.tscn","game/assets/Gamemode_Objects/Gamemode_Skull.tscn","game/assets/Gamemode_Objects/Gamemode_Flag_Blue.tscn","game/assets/Gamemode_Objects/Banner_Blue.tscn","game/assets/Space_Level_Objects/Computer_Static.tscn","game/assets/Space_Level_Objects/Space_Level.tscn","game/assets/Space_Level_Objects/Barrel_Rigid_Body.tscn","game/assets/Space_Level_Objects/Pillar_Static.tscn","game/assets/Space_Level_Objects/Light_Static.tscn","game/assets/Space_Level_Objects/Space_Mesh_Library_Scene.tscn","game/assets/Space_Level_Objects/Crate_Rigid_Body.tscn","game/assets/Space_Level_Objects/Light_Tall_Static.tscn"]
godot-haskell-project-generator: Maybe.fromJust: Nothing
CallStack (from HasCallStack):
  error, called at libraries/base/Data/Maybe.hs:148:21 in base:Data.Maybe
  fromJust, called at project-generator/Main.hs:649:91 in main:Main
@WinstonHartnett
Copy link
Contributor

I can't reproduce this. Is there anything else you can give?

@YellowOnion
Copy link
Author

Looks like the project generator needs a matching gdns for all tcsn files.

@YellowOnion
Copy link
Author

Never mind it's still absolutely pedantic:

stack exec godot-haskell-project-generator game src
Regenerating ...
["game/GUI.gdns","game/Player.gdns","game/World.gdns"]
["game/GUI.tscn","game/Player.tscn","game/World.tscn"]
godot-haskell-project-generator: project-generator/Main.hs:(661,20)-(664,38): Non-exhaustive patterns in case

@YellowOnion YellowOnion changed the title Project generator crashes on FPS tutorial example files, useless error message. Project generator needs to provide better error messages. Oct 22, 2021
@YellowOnion
Copy link
Author

@abarbu @DavidEichmann it would be nice if this program actually had useful error messages.

@YellowOnion
Copy link
Author

my assumption is that project-generator hates me using gdscript, if I want to use gdscript it breaks assumptions in how the project-generator parses the tscn and gdns files.

@lboklin
Copy link
Collaborator

lboklin commented Oct 22, 2021

I may have a fix for this, if indeed it's as I suspect because of scene instances marked as editable

@YellowOnion
Copy link
Author

YellowOnion commented Oct 22, 2021

If I move Player.tscn, and Player.gdns to a different folder I can get it generate my project files, registerAll' doesn't work though, and I'm not sure why.

Here's the project: https://github.com/YellowOnion/fps-game

@lboklin
Copy link
Collaborator

lboklin commented Oct 22, 2021

Can you try it now with the latest commits?

@YellowOnion
Copy link
Author

@lboklin I opened a pull request that fixes the issue :-)

@lboklin
Copy link
Collaborator

lboklin commented Oct 22, 2021

@YellowOnion That change was already made in the commits I've pushed

@lboklin
Copy link
Collaborator

lboklin commented Oct 22, 2021

Specifically 71df035

@YellowOnion
Copy link
Author

@lboklin Ahh okay you fixed it a different way I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants