Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When used with [Git::CommitBuild] only jobs using Perl versions provided by default work #34

Open
pwr22 opened this issue Mar 27, 2016 · 3 comments
Open

When used with [Git::CommitBuild] only jobs using Perl versions provided by default work #34

pwr22 opened this issue Mar 27, 2016 · 3 comments

Comments

@pwr22
Copy link
Contributor

pwr22 commented Mar 27, 2016

This seems to be because the .travis.yml committed to the build branch lacks any of the Perl helper stuff
@pwr22
Copy link
Contributor Author

pwr22 commented Mar 27, 2016

line 294 in lib/Dist/Zilla/Role/TravisYML.pm also appears to be broken too, which means that the helper stuff will also be omitted if support_builddir == 0

@pwr22
Copy link
Contributor Author

pwr22 commented Mar 27, 2016

I've confirmed the above issue occurs in the .travis.yml generated

@pwr22
Copy link
Contributor Author

pwr22 commented Mar 27, 2016

The issue was introduced in PR #23, behaviour was correct before

pwr22 added a commit to pwr22/Dist-Zilla-TravisCI that referenced this issue Mar 27, 2016
@pwr22
Fixing GH issue SineSwiper#34 - properly add default before_install i…
233b6d1 
…n all cases
@pwr22 pwr22 mentioned this issue Mar 27, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pwr22