Subscribe message by conversation

[akiroz]

subscribe will listen on all conversation events.... That's rarely what we want in practice, it should filter out messages for a specific conversion just like subscribeTypingIndicator.

[chpapa]

I think it is more optional and maybe can be a parameter in subscribe? If the developers don't care about other conversation they can simply ignore it at the logic?

On the other hand, I'm not sure if that have any implication to server loading / scalability.

[akiroz]

There are actually 2 versions of the typing indicator subscription: subscribeTypingIndicator and subscribeAllTypingIndicator, the first one filters by conversation and the 2nd one doesn't.
Kind of strange that there's only 1 subscribe (and I think it should be subscribeMessage).

[chpapa]

I agree subscribe is better renamed to subscribeMessage, found it odd when I first read it too.

[akiroz]

but now we can't rename it since the product is launched....... better add the new function and then do:

subscribe(...) {
  console.warn('subscribe is deprecated, please use subscribeMessage instead');
  ...
}