Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve progress bar handling for same URL navigation when disableSameUrl=false #78

Open
lunadelaet opened this issue Oct 24, 2024 · 0 comments

Comments

@lunadelaet
Copy link

Context:

We have a country switcher component that:

  • Uses router.push to navigate to the same URL (the URL remains unchanged).
  • Switches the country context, affecting how the data is fetched and displayed.
  • Triggers a data refresh via router.refresh to reflect the updated country context.

Problem:

When disableSameUrl=false, the progress bar continues to run indefinitely during this navigation process. We expect the progress bar to stop after the data is refreshed, but currently there is no way of doing this.

Expected Behavior:

The progress bar should stop once the data refresh is complete, even when navigating to the same URL with disableSameUrl=false.

@lunadelaet lunadelaet changed the title Improve Progress Bar Handling for Same URL Navigation When disableSameUrl=false Improve progress bar handling for same URL navigation when disableSameUrl=false Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant