Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add well-known sorting when selecting targets #9

Closed
maruina opened this issue Feb 15, 2021 · 1 comment
Closed

Add well-known sorting when selecting targets #9

maruina opened this issue Feb 15, 2021 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@maruina
Copy link
Contributor

maruina commented Feb 15, 2021

The target selection returns the list as we get that from the controller-runtime client. We should have a predictable order because

  • easier to test
  • easier to debug
  • if we released bad code we make sure we always update the same clusters first, reducing MTBF

Note that we don't want the same order for every ProgressiveRollout CRD as we would end up having the same "canary" cluster for every service. Using the PR CRD name as seed might be a good idea

@maruina maruina added this to the Milestone 2 milestone Feb 15, 2021
@maruina maruina added the enhancement New feature or request label Apr 19, 2021
@maruina maruina modified the milestones: Milestone 2, Milestone 3 Jun 30, 2021
@maruina
Copy link
Contributor Author

maruina commented Jan 10, 2022

We have a predictable order because we sort clusters and app by name. We should probably find a better way to do that when we implement #10

@maruina maruina closed this as completed Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant