-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZOOT-1101][BpkDialogInner]: Adds optional aria-modal to the dialog #3400
Conversation
Browser supportIf this is a visual change, make sure you've tested it in multiple browsers. |
Visit https://backpack.github.io/storybook-prs/3400 to see this build running in a browser. |
Visit https://backpack.github.io/storybook-prs/3400 to see this build running in a browser. |
Visit https://backpack.github.io/storybook-prs/3400 to see this build running in a browser. |
Visit https://backpack.github.io/storybook-prs/3400 to see this build running in a browser. |
This reverts commit 6be9dc7.
Visit https://backpack.github.io/storybook-prs/3400 to see this build running in a browser. |
Background:
It was discovered that it is possible to escape the modal with the screen reader. This can cause confusion if the content under the modal is unclear, and leaving the dialog may not be obvious, which can make travelers trapped behind an undismissable modal.
Action
In order to address the issue, it was decided to set an extra property to the modal that would prevent travelers from escaping the modal. To avoid breaking any other pages that use the modal, the property will be set as optional.
Changes
Fairly simple:
Screen.Recording.2024-04-30.at.15.55.09.mov
[KOA-123][BpkButton] Updating the colour
README.md
(If you have created a new component)README.md
.d.ts
) files updated