Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO JIRA][BpkPopover]: Make popover hoverable #3581

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

olliecurtis
Copy link
Member

Adds a new prop to make the popover have the ability to be triggered on hover hoverable by default is set to false and is just triggered by clicking the desired action.

When the property is set to true a user is able to hover over the popover and trigger it to open, then interact with any of the content inside.

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@olliecurtis olliecurtis added the minor Non breaking change label Aug 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

Visit https://backpack.github.io/storybook-prs/3581 to see this build running in a browser.

Copy link

github-actions bot commented Aug 9, 2024

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 236e96e

Copy link

Visit https://backpack.github.io/storybook-prs/3581 to see this build running in a browser.

Copy link

Visit https://backpack.github.io/storybook-prs/3581 to see this build running in a browser.

1 similar comment
Copy link

Visit https://backpack.github.io/storybook-prs/3581 to see this build running in a browser.

@jronald01
Copy link
Contributor

Percy tests failed on first run, but fine on re-run

@jronald01 jronald01 merged commit bf0d774 into main Nov 29, 2024
9 checks passed
@jronald01 jronald01 deleted the no-jira-make-popover-hoverable branch November 29, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Non breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants