Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Fix build removing nonexistent resource reference #55

Merged

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Jan 16, 2024

This removes the reference to Resources/CTK~vtkModalityWidget_LANG.ts originally introduced in 2facb49 ("Fix Slicer crash when using localized DICOM module", 2023-04-12) and partially removed in a76855c ("Mark translatable strings", 2024-01-03).

Issue was discovered while testing changes introduced in:

This removes the reference to `Resources/CTK~vtkModalityWidget_LANG.ts`
originally introduced in 2facb49 ("Fix Slicer crash when using localized
DICOM module", 2023-04-12) and partially removed in a76855c ("Mark
translatable strings", 2024-01-03)
@jcfr jcfr merged commit 5e4e769 into Slicer:main Jan 16, 2024
@jcfr jcfr deleted the update-cmakelists-removing-reference-to-removed-file branch January 16, 2024 02:28
@jcfr jcfr linked an issue Jan 16, 2024 that may be closed by this pull request
@lassoan
Copy link
Collaborator

lassoan commented Jan 16, 2024

Thank you, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

SlicerLanguagePacks unavailable in Extensions Manager
2 participants