Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cooldown Bug Report #13

Open
SDGNelson opened this issue May 15, 2020 · 1 comment
Open

Cooldown Bug Report #13

SDGNelson opened this issue May 15, 2020 · 1 comment

Comments

@SDGNelson
Copy link
Member

SDGNelson commented May 15, 2020

Originally posted by @Bradler26 in SmartlyDressedGames/Unturned-3.x-Community#1704 (comment)

My version fixed a bug where cooldowns were not working correctly. Rocketmod prioritised the highest cooldown for some reason and I believe it also ignored people with a 0s cooldown and rather gave them a cooldown with higher seconds (If they were in a group that had the same command with different cooldowns.

From scrolling through Dms he mentioned that this is how Rocketmod handled cooldowns so he made it prioritise the lowest cooldown instead

applyingPermissions.Where(p => p.Cooldown != 0).OrderByDescending(p => p.Cooldown).FirstOrDefault();

@rube200
Copy link

rube200 commented May 15, 2020

It is better if rocketmod handle it based on group priority.

In addition I think that rocketmod should save when the command was executed, because if the player permissions are changed the cooldown is the correct one.

Rocket.Core.CommandsRocketCommandManager this can be a "problem"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants