Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit API queries with new structure in place #160

Open
jomey opened this issue Oct 22, 2024 · 1 comment
Open

Revisit API queries with new structure in place #160

jomey opened this issue Oct 22, 2024 · 1 comment
Labels
API Any change/update related to the client side API enhancement New feature or request

Comments

@jomey
Copy link
Member

jomey commented Oct 22, 2024

After #104 is complete, let's revisit the API queries and see if we can simplify joins and make more use of subquery expressions.

@jomey jomey added enhancement New feature or request API Any change/update related to the client side API labels Oct 22, 2024
@aaarendt
Copy link
Contributor

In working on #170 I thought through other potential user needs within the API and am documenting here for possible inclusion when we revisit the queries:

  • include kwarg for searching on depth ranges (e.g. what are all the densities between 50 and 80 cm depth?)
  • the queries on values being greater / less than result in OR rather than AND logic (is this right?). Do we need to construct a specific case for ranges, e.g. 30 <= value <= 50? Seems like a common need, e.g. what are all the densities between 750 and 800 kg / m3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Any change/update related to the client side API enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants