-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove minimal spec #1119
Remove minimal spec #1119
Changes from all commits
f0c873a
98662af
eec937f
9d885ab
c8ba7da
7a0d233
0305c30
53f975f
6c32a3b
0839aef
781dcd8
e0cd0e0
7b14792
8ba2851
8a0f875
c80cba9
1e825ce
188ba63
d274243
1614113
143da4d
7308239
c41de10
fb67ceb
f87f4ef
79b8a30
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,9 +37,10 @@ | |
ps | ||
|
||
# typescript | ||
python3 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Python is necessary to build lodestar. |
||
nodePackages.pnpm | ||
nodePackages.yarn | ||
nodejs-18_x | ||
nodejs_20 | ||
(yarn.override { nodejs = nodejs_20; }) | ||
Comment on lines
+42
to
+43
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yarn comes with node 18 so we need to override it here. Lodestar 1.12.0 doesn't build with 18.16.1 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Btw the lodestar in our repo is the forked branch https://github.com/Snowfork/lodestar/tree/snowbridge which is based on 1.14.0 with a hack to work with node 18.16. Anyway, the hack here is necessary for working with node 20 so happy to see it. |
||
|
||
# ethereum | ||
foundry-bin | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -95,5 +95,3 @@ try-runtime = [ | |
"pallet-timestamp?/try-runtime", | ||
"sp-runtime/try-runtime", | ||
] | ||
beacon-spec-minimal = [] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No more this annoying feature... |
||
fast-runtime = ["beacon-spec-minimal"] |
Large diffs are not rendered by default.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,14 @@ | ||
// SPDX-License-Identifier: Apache-2.0 | ||
// SPDX-FileCopyrightText: 2023 Snowfork <[email protected]> | ||
use super::*; | ||
mod fixtures; | ||
mod util; | ||
|
||
use crate::Pallet as EthereumBeaconClient; | ||
use frame_benchmarking::v2::*; | ||
use frame_system::RawOrigin; | ||
|
||
#[cfg(feature = "beacon-spec-minimal")] | ||
mod fixtures_minimal; | ||
#[cfg(feature = "beacon-spec-minimal")] | ||
use fixtures_minimal::*; | ||
|
||
#[cfg(not(feature = "beacon-spec-minimal"))] | ||
mod fixtures_mainnet; | ||
#[cfg(not(feature = "beacon-spec-minimal"))] | ||
use fixtures_mainnet::*; | ||
use fixtures::*; | ||
|
||
use primitives::{ | ||
fast_aggregate_verify, prepare_aggregate_pubkey, prepare_aggregate_signature, | ||
|
@@ -151,16 +144,5 @@ mod benchmarks { | |
Ok(()) | ||
} | ||
|
||
#[cfg(feature = "beacon-spec-minimal")] | ||
impl_benchmark_test_suite!( | ||
EthereumBeaconClient, | ||
crate::mock::minimal::new_tester(), | ||
crate::mock::minimal::Test | ||
); | ||
#[cfg(not(feature = "beacon-spec-minimal"))] | ||
impl_benchmark_test_suite!( | ||
EthereumBeaconClient, | ||
crate::mock::mainnet::new_tester(), | ||
crate::mock::mainnet::Test | ||
); | ||
impl_benchmark_test_suite!(EthereumBeaconClient, crate::mock::new_tester(), crate::mock::Test); | ||
} |
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast runtime isn't necessary for the ethereum client anymore, since the runtime is sped up outside of the spec.