Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert Pause creates pause at layer+1 #7834

Closed
3 tasks done
jctune opened this issue Dec 24, 2024 · 1 comment · Fixed by #8017
Closed
3 tasks done

Insert Pause creates pause at layer+1 #7834

jctune opened this issue Dec 24, 2024 · 1 comment · Fixed by #8017
Labels
bug Something isn't working

Comments

@jctune
Copy link

jctune commented Dec 24, 2024 •
edited
Loading

Is there an existing issue for this problem?

  • I have searched the existing issues

OrcaSlicer Version

2.3.0-devel

Operating System (OS)

macOS

OS Version

Sequoia 15.2

Additional system information

No response

Printer

X1C

How to reproduce

  1. Slice a plate that contains an object that needs a pause
  2. In the preview window, go to the layer that needs a pause and add a pause at the desired layer.
  3. Slice the plate again
Screenshot 2024-12-24 at 12 35 26 PM Screenshot 2024-12-24 at 12 35 39 PM

Actual results

Pause gets inserted at the beginning of the next layer. While the slider on the right will indicate that the pause is on the correct layer, the next layer will be grey in the preview window indicating that it will pause here. Actual print behavior is to pause at desired layer +1.

Screenshot 2024-12-24 at 12 38 22 PM

A review of actual exported G-Code for this project also has the pause code inserted on desired layer +1
Screenshot 2024-12-24 at 12 50 18 PM

Expected results

The layer where the pause should occur should be both highlighted in grey in the preview window and the printer should actually pause at the beginning of that layer.

Project file & Debug log uploads

Gridfinity bin 2x6x5_PLA_4h32m.gcode.zip
SH2.3mf.zip
debug_Tue_Dec_24_12_43_23_8452.log.0.zip

Checklist of files to include

  • Log file
  • Project file

Anything else?

No response
@jctune jctune added the bug Something isn't working label Dec 24, 2024
@Noisyfox
Copy link
Collaborator

Noisyfox commented Jan 12, 2025 •
edited
Loading

It appears to be a rounding error caused by the adaptive layer height.
The actual z of layer 59 is 14.150783711069995, however when saving the custom gcode into file the z associated with the gcode is rounded into 14.151000022888184 which caused this issue.

Noisyfox added a commit to Noisyfox/OrcaSlicer that referenced this issue Jan 12, 2025
@Noisyfox
Compare the custom gcode z to 0.5*(layer_z[n] + layer_z[n+1]) inste…
a6db26f 
…ad of `EPSILON`

to compensate float rounding error during gcode processing (SoftFever#7834)
@Noisyfox Noisyfox mentioned this issue Jan 12, 2025
Merged
Noisyfox added a commit that referenced this issue Jan 22, 2025
@Noisyfox
Fix wrong custom gcode layer caused by rounding error (#8017)
fab7eaa 
Compare the custom gcode z to `0.5*(layer_z[n] + layer_z[n+1])` instead of `EPSILON`
to compensate float rounding error during gcode processing (#7834)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wrong custom gcode layer caused by rounding error Noisyfox/OrcaSlicer
2 participants
@Noisyfox @jctune