Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3mf object type to conform the 3mf core spec #7586

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fix 3mf object type to conform the 3mf core spec #7586

merged 1 commit into from
Nov 27, 2024

Conversation

Noisyfox
Copy link
Collaborator

Fix #7574

image

@Noisyfox Noisyfox marked this pull request as ready for review November 26, 2024 14:25
SoftFever
SoftFever approved these changes Nov 27, 2024
View reviewed changes
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you

@SoftFever SoftFever merged commit b38b913 into SoftFever:main Nov 27, 2024
15 of 16 checks passed
@Noisyfox Noisyfox deleted the bugfox/3mf-spec branch November 27, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoftFever SoftFever SoftFever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3MF files go against the specification. PrusaSlicer incompatibility
2 participants
@Noisyfox @SoftFever