Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with new mods which use the C runtime of soku #29

Open
wants to merge 1 commit into
base: better-mod-loader
Choose a base branch
from

Conversation

Hagb
Copy link

@Hagb Hagb commented Jun 11, 2024

This commit lets mods be loaded after the C runtime is initialized but before other static objects of soku are constructed.

  • Soku2 probably hooks constructors of static objects of soku. So it is too late to load Soku2 after these constructors are called.
  • Some new mods depend on the C runtime of soku. So they should be loaded after the C runtime of soku is initialized.

SetUnhandledExceptionFilter is now called before mods are loaded, so that mods can easily get the unhandled exception filter of SWRSToys and set their own ones when being initialized.

@Hagb Hagb force-pushed the crt branch 2 times, most recently from 3f3bf93 to 9e3ab44 Compare June 11, 2024 23:17
This commit lets mods be loaded after the C runtime is initialized but
before other static objects of soku are constructed.

- Soku2 probably hooks constructors of static objects of soku. So it
  is too late to load Soku2 after these constructors are called.
- Some new mods depend on the C runtime of soku. So they should be
  loaded after the C runtime of soku is initialized.

`SetUnhandledExceptionFilter` is now called before mods are loaded, so
that mods can easily get the unhandled exception filter of SWRSToys and
set their own ones when being initialized.
@Hagb Hagb changed the title Fix compatibility with new mods using C runtime of soku Fix compatibility with new mods which use the C runtime of soku Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant