Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved package vignette (Getting Started) for pkgdown #3

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Improved package vignette (Getting Started) for pkgdown #3

merged 3 commits into from
Sep 19, 2023

Conversation

stufield
Copy link
Contributor

@stufield stufield commented Sep 18, 2023 •
edited
Loading

Change type

Please check the relevant box(es):

Choose reviewer(s)

@stufield
Copy link
Contributor Author

This PR will run cleanly once the unit tests for plotConcord() are fixed.

amanda-hi
amanda-hi reviewed Sep 18, 2023
View reviewed changes
vignettes/SomaPlotr.Rmd Outdated
Using `plotPDFlist()`, a PDF plot can be generated from a list of numeric
vectors, with one smoothed kernel density curve per list item:
Using `plotPDFlist()`, a PDF plot can be generated from any arbitrary _named_
list of numeric vectors, with one smoothed kernel density curve per list element:

```{r pdf-list, fig.width = 6, fig.height = 5}
list_seq <- list(seq.17138.8 = data$seq.17138.8,
Copy link
Contributor

@amanda-hi amanda-hi Sep 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid confusion, I'd either A) use the already log10-transformed dataset to create the list for plotPDFlist(), or B) explain that this example is starting with the "raw" RFU data, unlike the example above (for plotPDFbyGroup()) which uses the log10-transformed dataset

Copy link
Contributor Author

@stufield stufield Sep 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. I was trying to show the actual strength of plotPDFlist() is that it doesn't matter what kind of data you're plotting, it could be RFU, but doesn't have to be. Perhaps we should simply simulate random normals for this one?

Do you think the lapply(list_seq, log10) is unclear?

amanda-hi
amanda-hi reviewed Sep 18, 2023
View reviewed changes
vignettes/SomaPlotr.Rmd Outdated Show resolved Hide resolved
amanda-hi
amanda-hi reviewed Sep 18, 2023
View reviewed changes
vignettes/SomaPlotr.Rmd Outdated Show resolved Hide resolved
@stufield stufield force-pushed the improvements-pkg-vignette branch 3 times, most recently from 659cce2 to 72bed5e Compare September 19, 2023 22:50
@stufield
Improved package vignette (Getting Started)
b4b827c 
- SomaPlotr.Rmd vignette cleanup and improvement
- word smithing and re-creating of example to better
  showcase the functionality in relation to "real" SomaScan
- setting seeds to reproduct and generate "realistic" data
- use more log10() data in examples
- fixes #2 and #6
@stufield stufield merged commit 5d9f240 into main Sep 19, 2023
3 checks passed
@stufield stufield mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanda-hi amanda-hi amanda-hi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up Getting Started vignette examples
2 participants
@stufield @amanda-hi