Resolve R CMD check failures #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanda-hi
force-pushed
the
resolve-test-failures
branch
5 times, most recently
from
69ade10
to
fab0ac6
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 42.89% 44.74% +1.85%
==========================================
Files 29 29
Lines 1119 1104 -15
==========================================
+ Hits 480 494 +14
+ Misses 639 610 -29 ☔ View full report in Codecov by Sentry. |
amanda-hi
force-pushed
the
resolve-test-failures
branch
4 times, most recently
from
69f9a38
to
f1757cb
Compare
- the `scale_name` argument of ggplot2::discrete_scale() was deprecated in ggplot v3.5.0 - removed all instances of `scale_name =` from the custom scales defined in SomaPlotr (ex. `scale_color_soma()`)
amanda-hi
force-pushed
the
resolve-test-failures
branch
from
f1757cb
to
b48e355
Compare
amanda-hi
force-pushed
the
resolve-test-failures
branch
from
b48e355
to
0556f18
Compare
- updated 'checkout' action to v4, as a node used by the previous version (v3) is now deprecated - specified R version to use on MacOS and Windows, to match SomaLogic's development and maintenance environment
amanda-hi
force-pushed
the
resolve-test-failures
branch
2 times, most recently
from
d0f5280
to
3093a43
Compare
- 'run-on' OS (defined in GHA *.yaml files) was previously set to MacOS-12 - current SomaPlotr developer/maintainer environments use MacOS-14; the difference in OS versions resulted in testthat snapshot testing errors - updated run-on OS to 'macos-14' and re-generated all required unit test snapshots
amanda-hi
force-pushed
the
resolve-test-failures
branch
from
3093a43
to
b88f3b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of Pull Request
The OS specified for GHA checks and tests was recently updated from
ubuntu-latesttomacos-12. This has resulted in failures for both R CMD checks and testing suites when GHA PR checks are performed, when they previously were consistently passing. There must be a mismatch in the environments used by GHA checks and the SomaPlotr developers/maintainers, which needs to be resolved so that GHA checks match checks performed locally.The
*.yamlconfig files for GHA need updates to better sync these environments.Internal Use Only
Change Type
Please check the relevant box(es):
Reviewer by Department