Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for a warning message for queries involving non-human proteins #3

Open
amanda-hi opened this issue Oct 12, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@amanda-hi
Copy link
Contributor

amanda-hi commented Oct 12, 2023

It would be helpful to have a signal condition (either error or warning message) that will be activated when a user requests annotations for a mouse Fc or other non-human protein that doesn't have a cleanly mapped Entrez ID, and therefore is not available in the package. Currently, if a user searches for one of these analytes, they will get no annotation entries back & an error saying the key is invalid. This could be confusing or misleading (they could think they made a mistake with their query, misunderstood how to use the package, etc.).

Example:

reprex::reprex({
      library(SomaScan.db)
      select(SomaScan.db, "10034-16", columns = c("UNIPROT", "ENTREZID"))
})

See this chapter of Advanced R for implementing signaling conditions.

@amanda-hi amanda-hi self-assigned this Oct 26, 2023
@amanda-hi amanda-hi added the enhancement New feature or request label Oct 26, 2023
@amanda-hi
Copy link
Contributor Author

amanda-hi commented Mar 29, 2024

The SeqIds for these entries (i.e. non-human proteins) are currently not part of the SQLite db for this package. To identify and signal a message whenever these values are queried, there would need to be some form of underlying data structure in the package that maintains a list of these IDs. This could possibly be an un-exported data object (like somascan_menus but for internal use only).

Handling internal data objects when LazyData = FALSE: https://stackoverflow.com/questions/9521009/how-do-you-handle-r-data-internal-to-a-package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant