Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform repository directory names #514

Open
ghost opened this issue Sep 17, 2020 · 6 comments
Open

Cross-platform repository directory names #514

ghost opened this issue Sep 17, 2020 · 6 comments

Comments

@ghost
Copy link

ghost commented Sep 17, 2020

Super minor nits to consider:

  • Replace spaces in the repository's directory names with underscores.
  • Ensure that the directory names are cross-platform (e.g., stick to ASCII characters if possible).
  • Remove hyphens, commas, apostrophes, parentheses, and other punctuation from directory names.
  • Use at most one period in directory and file names.
  • Delete old directories if they are no longer used (let the repository handle archival).

I was informed that some repo directory names are not handled well by Windows. For example:

Variable Extension - optical and width/Nathan Wilis /NathanWillis Merriweather--Cyrillic-lc-upright.glyphs

The extra space at the end of the directory name, Nathan Wilis , could pose a problem on Windows, for example. Highly recommend normalizing the directory names.

@ghost ghost changed the title Cross-platform directory names Cross-platform repository directory names Sep 17, 2020
@EbenSorkin
Copy link
Contributor

EbenSorkin commented Sep 17, 2020 via email

@tetrachromium
Copy link
Contributor

I have a fix for this issue, but cannot push it.

@EbenSorkin
Copy link
Contributor

Isn't a pull request the normal way to fix?

@EbenSorkin
Copy link
Contributor

Also, I will fix this after I consult with the client (Google) about it because although there may be a Github standard way to do this there may also be a Google Fonts standard way and in candor the later will win if they are opposed.

@tetrachromium
Copy link
Contributor

tetrachromium commented Sep 18, 2020

A pull request certainly is the normal way to provide you with the fix. To create a pull request, I first need permission to push to your repository.

Dave and I are software developers. By all means, feel free to consult with Google, but we work with Git repositories for a living. If Google has an opinion, they are going to prefer best practices and conventions that are cross-platform compatible.

The fix is quite simple. Not all operating systems allow trailing space characters in folder and file names. The path:
Variable Extension - optical and width/Nathan Wilis (with the trailing space) prevents the entire repository from being cloned onto a Windows machine. Just do a rename on that folder to delete the trailing space.

My primary interest in this issue is being able to clone the repository onto a Windows machine, which I cannot do at the moment.

@j-f1
Copy link
Contributor

j-f1 commented Sep 18, 2020

To create a pull request, I first need permission to push to your repository.

You should also be able to fork the repository (https://github.com/SorkinType/Merriweather/fork) to your own account, make changes there, then open a pull request to this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants