Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from thiserror to snafu for no_std #1105

Open
vlopes11 opened this issue Oct 24, 2023 · 4 comments
Open

Switch from thiserror to snafu for no_std #1105

vlopes11 opened this issue Oct 24, 2023 · 4 comments
Labels
Needs Grooming question Further information is requested Small Use this label for quick cleanup and maintenance tasks

Comments

@vlopes11
Copy link
Contributor

thiserror has no short-term plans to support no_std.

Alternatively, we can use snafu - a similar library with no_std support. This will reduce code complexity for no_std implementations, as currently we have to feature shield all variants of error implementations, causing a lot of code bloat.

@vlopes11 vlopes11 added question Further information is requested Needs Grooming Small Use this label for quick cleanup and maintenance tasks labels Oct 24, 2023
@sudipghimire533
Copy link

is this on progress. I can help with this one if needed

@vlopes11
Copy link
Contributor Author

First and foremost, thanks for the positive collaboration @sudipghimire533 .

It would be awesome to have your collaboration on this one, but we are still discussing on whether or not we are actually going to perform this change.

While it is desirable to have no-std support for these error helpers, we are concerned this might be a big change, as anyhow is used everywhere - both in our code base and in our 3rd party dependencies. It might be also that when we are finally done with the migration, thiserror already supports no-std.

With that said, we'd like to wait a bit more until we finally decide if we are going this direction.

All help is welcome! You can take a look into the "good first issue" label for different tasks. However, the ones tagged with "question" or "needs grooming" will probably go through a round of discussions before the actual coding starts.

@sudipghimire533
Copy link

I understand.

@DaviRain-Su
Copy link

maybe use displaydoc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Grooming question Further information is requested Small Use this label for quick cleanup and maintenance tasks
Projects
None yet
Development

No branches or pull requests

3 participants