-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archival state support for state_db and native_db #1170
base: nightly
Are you sure you want to change the base?
Conversation
Codecov Report
Additional details and impacted files
|
module-system/module-implementations/sov-bank/tests/archival_query_test.rs
Outdated
Show resolved
Hide resolved
version: Option<Version>, | ||
) -> anyhow::Result<Option<Vec<u8>>> { | ||
let version_to_use = version.unwrap_or_else(|| self.get_next_version()); | ||
let mut iter = self.db.iter::<ModuleAccessoryState>()?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change, we use iterator on every access to the database.
Do we want to measure performance impact on regular execution?
Maybe it is too late to discuss it, but it looks like archival state taxes on regular execution.
I am raising this point, because together with ForkManagement our storage can become bottleneck.
|
Description
Basic support at the code level to read archival state for
Changes
Pending
Expose archival state via RPC macros