Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and augment demo rollup benches #1282

Merged
merged 10 commits into from
Jan 9, 2024

Conversation

theochap
Copy link
Contributor

@theochap theochap commented Jan 5, 2024

Description

This simple PR refactors demo-rollup benches by incorporating the data generators module and building larger benchmark tests. It also makes some refactoring to certain parts of the stf-blueprint to be able to capture benchmarking cycles with a finer precision.

Linked Issues

Testing

Ran the benchmarks and reported the results

Docs

The results are reported in the demo-rollup/benches/prover/README.md

Cargo.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (de526a6) 79.2% compared to head (709b3f7) 78.8%.
Report is 1 commits behind head on nightly.

Additional details and impacted files
Files Coverage Δ
...ystem/sov-data-generators/src/value_setter_data.rs 86.0% <ø> (ø)
...ystem/sov-modules-stf-blueprint/src/tx_verifier.rs 100.0% <100.0%> (ø)
...tem/sov-modules-stf-blueprint/src/stf_blueprint.rs 88.8% <98.1%> (+1.1%) ⬆️
module-system/sov-data-generators/src/lib.rs 86.3% <0.0%> (ø)
module-system/sov-state/src/zk_storage.rs 65.9% <78.4%> (+8.4%) ⬆️
module-system/sov-data-generators/src/bank_data.rs 80.5% <2.8%> (ø)

... and 10 files with indirect coverage changes

theochap and others added 3 commits January 5, 2024 12:28
Co-authored-by: Nikolai Golub <[email protected]>
…:Sovereign-Labs/sovereign-sdk into refactor_and_augment_demo-rollup_benches
@theochap theochap requested a review from neysofu January 8, 2024 11:39
@dubbelosix dubbelosix added this pull request to the merge queue Jan 9, 2024
Merged via the queue into nightly with commit a8a234c Jan 9, 2024
18 checks passed
@dubbelosix dubbelosix deleted the refactor_and_augment_demo-rollup_benches branch January 9, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants