Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ImNodes to latest version #193

Closed
serivesmejia opened this issue Jul 26, 2023 · 0 comments · Fixed by #282
Closed

Update ImNodes to latest version #193

serivesmejia opened this issue Jul 26, 2023 · 0 comments · Fixed by #282
Labels
missing binding Some of the original library API is missing

Comments

@serivesmejia
Copy link
Contributor

serivesmejia commented Jul 26, 2023

Version

1.86.10

What part of the binding has gaps?

ImNodes

What is missing?

After my issue (#86 ) about assertion errors not being debuggable was addressed (thank you!), I realized that my main binding of interest for this was not using ImGui's IM_ASSERT macro, using assert.h instead, which does not trigger the Java callback implemented to trace these crashes. I went on to open a new issue on the imnodes repository to address this. It has been fixed ever since, however, upon coming back to the project I was developing, I realized that imgui-java's bindings haven't been updated to receive these changes. Would there be a possibility of including them in the next release of imgui-java?

Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing binding Some of the original library API is missing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant