Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Bindings / Incorrect return types #290

Closed
baileysostek opened this issue Oct 21, 2024 · 0 comments · Fixed by #282
Closed

Missing Bindings / Incorrect return types #290

baileysostek opened this issue Oct 21, 2024 · 0 comments · Fixed by #282
Labels
missing binding Some of the original library API is missing

Comments

@baileysostek
Copy link

Version

1.87.5

What part of the binding has gaps?

ImNodes

What is missing?

Something is missing! I think the return types of all of these getters are supposed to be numeric instead of void. I am not sure if the value is returned in subpixel floating point or pixel based integer, but if i had to guess the positions are represented as integers.

Here is the code that I think needs to change to return integer instead of void:
imgui-java/imgui-binding/src/generated/java/imgui/extension/imnodes /ImNodes.java

Lines 555 - 577

public static void getNodeScreenSpacePos(final int nodeId) {
    nGetNodeScreenSpacePos(nodeId);
}

private static native void nGetNodeScreenSpacePos(int nodeId); /*
    ImNodes::GetNodeScreenSpacePos(nodeId);
*/

public static void getNodeEditorSpacePos(final int nodeId) {
    nGetNodeEditorSpacePos(nodeId);
}

private static native void nGetNodeEditorSpacePos(int nodeId); /*
    ImNodes::GetNodeEditorSpacePos(nodeId);
*/

public static void getNodeGridSpacePos(final int nodeId) {
    nGetNodeGridSpacePos(nodeId);
}

private static native void nGetNodeGridSpacePos(int nodeId); /*
    ImNodes::GetNodeGridSpacePos(nodeId);
*/
@baileysostek baileysostek added the missing binding Some of the original library API is missing label Oct 21, 2024
@baileysostek baileysostek changed the title Missing Bindings: Missing Bindings / Incorrect return types Oct 21, 2024
@SpaiR SpaiR linked a pull request Oct 21, 2024 that will close this issue
5 tasks
@SpaiR SpaiR closed this as completed in 7be2a29 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing binding Some of the original library API is missing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant