From 60b81121f2a00cf28c0e94c122a603423286f3c5 Mon Sep 17 00:00:00 2001 From: Sparronator9999 <86388887+Sparronator9999@users.noreply.github.com> Date: Tue, 3 Sep 2024 08:58:04 +1000 Subject: [PATCH] Fix "GitHub Issues" button in crash dialog not opening this project's GitHub page - Remove two unused usings from the last commit --- YAMDCC.GUI/Dialogs/CrashDialog.Designer.cs | 18 +++++++++--------- YAMDCC.GUI/Dialogs/CrashDialog.cs | 4 +--- YAMDCC.Service/svcFanControl.cs | 2 -- 3 files changed, 10 insertions(+), 14 deletions(-) diff --git a/YAMDCC.GUI/Dialogs/CrashDialog.Designer.cs b/YAMDCC.GUI/Dialogs/CrashDialog.Designer.cs index df89e4e..6c60b53 100644 --- a/YAMDCC.GUI/Dialogs/CrashDialog.Designer.cs +++ b/YAMDCC.GUI/Dialogs/CrashDialog.Designer.cs @@ -82,19 +82,19 @@ private void InitializeComponent() this.tableLayoutPanel1.SetColumnSpan(this.lblError, 2); this.lblError.Dock = System.Windows.Forms.DockStyle.Fill; this.lblError.Location = new System.Drawing.Point(3, 3); - this.lblError.Margin = new System.Windows.Forms.Padding(3); + this.lblError.Margin = new System.Windows.Forms.Padding(3, 3, 3, 3); this.lblError.Name = "lblError"; this.lblError.Size = new System.Drawing.Size(394, 60); this.lblError.TabIndex = 0; - this.lblError.Text = "YAMDCC has crashed!\r\n\r\nBefore reporting a bug, try again on the latest version of" + - " YAMDCC.\r\nIf the crash still occurs, please include the following crash report:"; + this.lblError.Text = "YAMDCC has crashed!\r\n\r\nBefore reporting a bug, try again on the latest commit of " + + "YAMDCC.\r\nIf the crash still occurs, please include the following crash report:"; // // btnReportIssue // this.btnReportIssue.AutoSize = true; - this.btnReportIssue.Location = new System.Drawing.Point(3, 222); + this.btnReportIssue.Location = new System.Drawing.Point(3, 221); this.btnReportIssue.Name = "btnReportIssue"; - this.btnReportIssue.Size = new System.Drawing.Size(100, 25); + this.btnReportIssue.Size = new System.Drawing.Size(100, 26); this.btnReportIssue.TabIndex = 1; this.btnReportIssue.Text = "GitHub Issues"; this.btnReportIssue.UseVisualStyleBackColor = true; @@ -107,10 +107,10 @@ private void InitializeComponent() this.flowLayoutPanel1.Controls.Add(this.btnSaveReport); this.flowLayoutPanel1.Dock = System.Windows.Forms.DockStyle.Fill; this.flowLayoutPanel1.FlowDirection = System.Windows.Forms.FlowDirection.RightToLeft; - this.flowLayoutPanel1.Location = new System.Drawing.Point(106, 219); + this.flowLayoutPanel1.Location = new System.Drawing.Point(106, 218); this.flowLayoutPanel1.Margin = new System.Windows.Forms.Padding(0); this.flowLayoutPanel1.Name = "flowLayoutPanel1"; - this.flowLayoutPanel1.Size = new System.Drawing.Size(294, 31); + this.flowLayoutPanel1.Size = new System.Drawing.Size(294, 32); this.flowLayoutPanel1.TabIndex = 2; // // btnExit @@ -142,7 +142,7 @@ private void InitializeComponent() this.groupBox1.Dock = System.Windows.Forms.DockStyle.Fill; this.groupBox1.Location = new System.Drawing.Point(3, 69); this.groupBox1.Name = "groupBox1"; - this.groupBox1.Size = new System.Drawing.Size(394, 147); + this.groupBox1.Size = new System.Drawing.Size(394, 146); this.groupBox1.TabIndex = 3; this.groupBox1.TabStop = false; this.groupBox1.Text = "Crash report"; @@ -157,7 +157,7 @@ private void InitializeComponent() this.txtStackTrace.Name = "txtStackTrace"; this.txtStackTrace.ReadOnly = true; this.txtStackTrace.ScrollBars = System.Windows.Forms.ScrollBars.Vertical; - this.txtStackTrace.Size = new System.Drawing.Size(388, 125); + this.txtStackTrace.Size = new System.Drawing.Size(388, 124); this.txtStackTrace.TabIndex = 0; // // CrashDialog diff --git a/YAMDCC.GUI/Dialogs/CrashDialog.cs b/YAMDCC.GUI/Dialogs/CrashDialog.cs index 39960c6..1d183f8 100644 --- a/YAMDCC.GUI/Dialogs/CrashDialog.cs +++ b/YAMDCC.GUI/Dialogs/CrashDialog.cs @@ -19,9 +19,7 @@ public CrashDialog(Exception ex, bool threadException) private void btnReportIssue_Click(object sender, EventArgs e) { - // TODO: work out GitHub Issues stuff - // Process.Start("https://github.com/Sparronator9999/MSIFanControl/issues"); - Process.Start("https://youtu.be/dQw4w9WgXcQ"); + Process.Start("https://github.com/Sparronator9999/YAMDCC/issues"); } private void btnSaveReport_Click(object sender, EventArgs e) diff --git a/YAMDCC.Service/svcFanControl.cs b/YAMDCC.Service/svcFanControl.cs index 3ee98e0..7669a28 100644 --- a/YAMDCC.Service/svcFanControl.cs +++ b/YAMDCC.Service/svcFanControl.cs @@ -18,8 +18,6 @@ using System.ComponentModel; using System.IO; using System.IO.Pipes; -using System.Security.AccessControl; -using System.Security.Principal; using System.ServiceProcess; using YAMDCC.Config; using YAMDCC.ECAccess;