From 53431a9bb50362e8bd5bf96bc70484fd52330c66 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jonas=20B=C3=BClow=20Knudsen?=
 <12843299+JonasBK@users.noreply.github.com>
Date: Thu, 2 May 2024 00:03:59 -0700
Subject: [PATCH] feat: collect unresolved published cert templates (#121)

---
 src/CommonLib/Processors/CertAbuseProcessor.cs | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/src/CommonLib/Processors/CertAbuseProcessor.cs b/src/CommonLib/Processors/CertAbuseProcessor.cs
index 066965b5..005e08bf 100644
--- a/src/CommonLib/Processors/CertAbuseProcessor.cs
+++ b/src/CommonLib/Processors/CertAbuseProcessor.cs
@@ -170,14 +170,23 @@ public async Task<EnrollmentAgentRegistryAPIResult> ProcessEAPermissions(string
             return ret;
         }
         
-        public IEnumerable<TypedPrincipal> ProcessCertTemplates(string[] templates, string domainName)
+        public (IEnumerable<TypedPrincipal> resolvedTemplates, IEnumerable<String> unresolvedTemplates) ProcessCertTemplates(string[] templates, string domainName)
         {
+            var resolvedTemplates = new List<TypedPrincipal>();
+            var unresolvedTemplates = new List<String>();
+
             var certTemplatesLocation = _utils.BuildLdapPath(DirectoryPaths.CertTemplateLocation, domainName);
             foreach (var templateCN in templates)
             {
                 var res = _utils.ResolveCertTemplateByProperty(Encoder.LdapFilterEncode(templateCN), LDAPProperties.CanonicalName, certTemplatesLocation, domainName);
-                yield return res;
+                if (res != null) {
+                    resolvedTemplates.Add(res);
+                } else {
+                    unresolvedTemplates.Add(templateCN);
+                }
             }
+
+            return (resolvedTemplates: resolvedTemplates, unresolvedTemplates: unresolvedTemplates);
         }
 
         /// <summary>