Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw ddl not found exception when missing SharpHoundRPC on init #107

Closed
wants to merge 1 commit into from

Conversation

definitelynotagoblin
Copy link
Contributor

Description

We want to exit SharpHound collection if SharpHoundRPC.dll is missing as we'd rather not support incomplete installations.

Motivation and Context

https://specterops.atlassian.net/browse/BP-316

How Has This Been Tested?

Install SharpHound to environment, remove SharpHoundRPC.dll, run SharpHound collection.

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@definitelynotagoblin
Copy link
Contributor Author

Waiting on author for testing.

@rvazarkar
Copy link
Contributor

I think we might want to move this logic to the clients instead of supporting it in CommonLib directly. Installation integrity should be handled there

@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants