Update WellKnownPrincipal.cs #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct type for this is user. this small thing made a huge confusion for some people today :( i think this was caused from copy pasting s-1-5-15 the one above it in a fix long ago. do not confuse IUSR type with IIS_IUSRS https://learn.microsoft.com/en-us/windows-server/identity/ad-ds/manage/understand-security-identifiers
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Could you retarget this against the |
|
You'll also need to fix the test in |
|
rvazarkar
approved these changes
Jul 25, 2024
|
Thanks for the MR, looks great! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The correct type for the IUSR (S-1-5-17) is user, not group.
this small thing made a huge confusion for some people today :( i think this was caused from copy pasting s-1-5-15 the one above it in a fix long ago.
do not confuse IUSR type with IIS_IUSRS
https://learn.microsoft.com/en-us/windows-server/identity/ad-ds/manage/understand-security-identifiers
Motivation and Context
this small thing made a huge confusion for some people today :(
i think this was caused from copy pasting s-1-5-15 the one above it in a fix long ago.
How Has This Been Tested?
single run on empty dc with iis installed
Screenshots (if appropriate):
Types of changes
Checklist: