From 920514f9c07b651d4398926bd74f046694d2e977 Mon Sep 17 00:00:00 2001 From: nurfed Date: Sat, 23 Dec 2023 22:45:41 +0100 Subject: [PATCH] Check if ResolveAccountName returns a value --- src/CommonLib/Processors/GPOLocalGroupProcessor.cs | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/CommonLib/Processors/GPOLocalGroupProcessor.cs b/src/CommonLib/Processors/GPOLocalGroupProcessor.cs index 419a3efb..fa7041be 100644 --- a/src/CommonLib/Processors/GPOLocalGroupProcessor.cs +++ b/src/CommonLib/Processors/GPOLocalGroupProcessor.cs @@ -531,6 +531,11 @@ internal IEnumerable ProcessGPOXmlFile(string basePath, string gpoD var domain = s[0]; var res = _utils.ResolveAccountName(name, domain); + if (res == null) + { + _log.LogWarning("Failed to resolve member {memberName}", memberName); + continue; + } ga.Target = GroupActionTarget.LocalGroup; ga.TargetSid = res.ObjectIdentifier; ga.TargetType = res.ObjectType; @@ -540,6 +545,11 @@ internal IEnumerable ProcessGPOXmlFile(string basePath, string gpoD else { var res = _utils.ResolveAccountName(memberName, gpoDomain); + if (res == null) + { + _log.LogWarning("Failed to resolve member {memberName}", memberName); + continue; + } ga.Target = GroupActionTarget.LocalGroup; ga.TargetSid = res.ObjectIdentifier; ga.TargetType = res.ObjectType;